[minor_changes]Adding guidelines for Ansible ACI module developement (DCNE-80) #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

anvitha-jain wants to merge 8 commits into CiscoDevNet:master from anvitha-jain:module_guide

Collaborator

anvitha-jain commented May 14, 2025 •

edited

Loading

solves #278

anvitha-jain self-assigned this

anvitha-jain requested review from akinross, gmicol, lhercot, sajagana, samiib and shrsr as code owners

May 14, 2025 20:51

anvitha-jain added the documentation label

anvitha-jain force-pushed the module_guide branch from 44d838f to 7785013 Compare

June 3, 2025 19:19

anvitha-jain linked an issue

that may be closed by this pull request

Migrate Cisco ACI development and scenario guides to this collection. (DCNE-80) #278

Open

2 tasks

github-actions bot changed the title ~~[minor_changes]Adding guidelines for Ansible ACI module developement~~ [minor_changes]Adding guidelines for Ansible ACI module developement (DCNE-80)

akinross requested changes

View reviewed changes

Collaborator

akinross left a comment

sanity fails

anvitha-jain force-pushed the module_guide branch from 7785013 to 1c3eb49 Compare

June 10, 2025 18:02

samiib requested changes

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

anvitha-jain requested review from samiib and akinross

June 17, 2025 16:25

sajagana requested changes

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

sajagana reviewed

View reviewed changes

Collaborator

sajagana left a comment •

edited by anvitha-jain

Loading

Can we also mention the black formatting and flake8 checks in a few points?

Added

DevSinha13 reviewed

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

DevSinha13 reviewed

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

DevSinha13 reviewed

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

DevSinha13 reviewed

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

DevSinha13 reviewed

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

DevSinha13 reviewed

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

DevSinha13 reviewed

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

DevSinha13 reviewed

View reviewed changes

docs/docsite/rst/developing_modules_general_aci.rst Outdated Show resolved Hide resolved

samiib previously approved these changes

View reviewed changes

Collaborator

samiib left a comment

LGTM!

anvitha-jain dismissed samiib’s stale review via

d031451

June 30, 2025 16:09

anvitha-jain requested review from sajagana and samiib

June 30, 2025 16:10

samiib requested changes

View reviewed changes

plugins/modules/aci_l3out_static_routes.py Outdated

Collaborator

samiib Jul 25, 2025

Was this module intended to be removed?

Collaborator

samiib Jul 30, 2025 •

edited by anvitha-jain

Loading

Looks like this module is still being removed.

:-> Added back

anvitha-jain requested a review from samiib

July 25, 2025 17:56

shrsr requested changes

View reviewed changes

docs/aci_collection_git_contribution_workflow.md Outdated Show resolved Hide resolved

docs/aci_collection_git_contribution_workflow.md Outdated Show resolved Hide resolved

anvitha-jain force-pushed the module_guide branch from 0d4b574 to b7d3912 Compare

July 29, 2025 02:21

anvitha-jain requested a review from shrsr

July 29, 2025 02:27

shrsr requested changes

View reviewed changes

docs/aci_collection_git_contribution_workflow.md Outdated Show resolved Hide resolved

docs/developing_aci_module_guidelines.md Outdated Show resolved Hide resolved

docs/developing_aci_module_guidelines.md Outdated Show resolved Hide resolved

anvitha-jain force-pushed the module_guide branch from b7d3912 to 03c17e7 Compare

July 29, 2025 18:32

shrsr and others added 6 commits

July 29, 2025 11:33


          [minor_changes]Adding guidelines for Ansible ACI module developement

0ba0099


          [ignore_changes] corrected spelling and grammar.

d75a239


          [ignore_changes] Corrected spelling and grammar.

cfb0439


          [ignore_changes] Added additional tests like flake8 and black in test…

6ee4d20

…ing section.


          [ignore_changes] Santity section yet to be changed.

04694f0


          [minor_change] Changed the format of the documentation developing_aci…

149b348

…_modules_guildelines is the new changed file along with sections segrigated in other files.

anvitha-jain force-pushed the module_guide branch from 03c17e7 to 8798082 Compare

July 29, 2025 18:34

anvitha-jain requested a review from shrsr

July 29, 2025 18:56

anvitha-jain force-pushed the module_guide branch from 8798082 to 54bd8ca Compare

July 29, 2025 19:01

shrsr requested changes

View reviewed changes

docs/developing_aci_module_guidelines.md Outdated Show resolved Hide resolved

anvitha-jain force-pushed the module_guide branch from 54bd8ca to 03a9eb5 Compare

July 29, 2025 21:45


          [minor_change] Change the format from reStructuredText file type to M…

b1d60d9

…arkdown type.

anvitha-jain force-pushed the module_guide branch from 03a9eb5 to b1d60d9 Compare

July 29, 2025 23:48

anvitha-jain requested a review from shrsr

July 29, 2025 23:48

samiib requested changes

View reviewed changes

plugins/modules/aci_l3out_static_routes.py Outdated

Collaborator

samiib Jul 30, 2025 •

edited by anvitha-jain

Loading

Looks like this module is still being removed.

:-> Added back

anvitha-jain requested a review from samiib

July 30, 2025 18:29


          [ignore] Added aci_l3out_static_routes.py file back.

76000df

anvitha-jain force-pushed the module_guide branch from d62b710 to 76000df Compare

July 31, 2025 17:15

shrsr approved these changes

View reviewed changes

Collaborator

shrsr left a comment

LGTM

samiib approved these changes

View reviewed changes

Collaborator

samiib left a comment

LGTM

sajagana approved these changes

View reviewed changes

Collaborator

sajagana left a comment

LGTM!

gmicol approved these changes

View reviewed changes

Collaborator

gmicol left a comment

LGTM

akinross approved these changes

View reviewed changes

Collaborator

akinross left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shrsr shrsr approved these changes

akinross akinross approved these changes

sajagana sajagana approved these changes

samiib samiib approved these changes

gmicol gmicol approved these changes

lhercot Awaiting requested review from lhercot lhercot is a code owner

DevSinha13 Awaiting requested review from DevSinha13

Labels